TOPIC: Vina Jssor Content Slider

Vina Jssor Content Slider 9 years 6 months ago #562

  • Ryan Drewniak
  • Ryan Drewniak's Avatar
  • OFFLINE
  • New Member
  • Posts: 2
  • Orders: 0
  • Download: 0
  • Karma: 0
I've been experimenting with this module and I had noticed an issue with code validation.

The HTML generated by the module simply will not validate, specifically the custom attributes utilized in the captions (ie. <div u="caption" t="*" class="vcs-slide-text" style="top: 10px; left: 10px; width: 480px; height: 300px;">). Is an issue that is being addressed?

I also am having trouble customizing the text color. I change it in the module tab, but it remains white. It appears as though it's hard-coded in the asset CSS files for the module installation ( jssor.css ), making the whole feature in the admin panel seemingly useless.
Last Edit: 9 years 6 months ago by Ryan Drewniak.
The administrator has disabled public write access.

Vina Jssor Content Slider 9 years 6 months ago #564

  • Rango
  • Rango's Avatar
  • OFFLINE
  • Administrator
  • Posts: 848
  • Thank you received: 115
  • Karma: 22
Dear Ryan Drewniak,

Thank you for your report. We've fixed problem with text color. Please download latest version and install in your site.
About code validation, our module need new attribute (u="caption" t="*") to work, so we can't remove it, but i don't think it is big problem.
If you see any other problem or need any other help, please don't hesitate let us know.

Best regards.
No pain no gain! Accept the pain, future will be fruitful!
The administrator has disabled public write access.

Vina Jssor Content Slider 9 years 6 months ago #576

  • Ryan Drewniak
  • Ryan Drewniak's Avatar
  • OFFLINE
  • New Member
  • Posts: 2
  • Orders: 0
  • Download: 0
  • Karma: 0
Thanks for the follow up. I really appreciate it.

I had one though regarding the code validation issues. You could potentially modify the attribute titles to fit with the custom attribute schema established in HTML5 (you could use data-u="caption" instead of u="caption"). Granted that change would have to be carried throughout the entire extension, but in theory it could work.
The administrator has disabled public write access.

Vina Jssor Content Slider 9 years 6 months ago #580

  • Rango
  • Rango's Avatar
  • OFFLINE
  • Administrator
  • Posts: 848
  • Thank you received: 115
  • Karma: 22
Dear Ryan Drewniak,

Yes, you are right. We can use use data-u="caption" instead of u="caption". But as you know, we need change all code of this extension. It's really big change.
We will thinking about it, and maybe change it in the next version.

Best regards.
No pain no gain! Accept the pain, future will be fruitful!
The administrator has disabled public write access.

regarding slide items 9 years 6 months ago #648

Good module.
But I just have a question. Can we have an option such that selecting category as source for slides and also filter such that the slides are from content of particular category.

It will be a full fledged module with swipe touch if you add filter option to display the article content of particular category.

For example I added the image.


Thank you
Attachments:
The administrator has disabled public write access.

regarding slide items 9 years 6 months ago #651

  • Rango
  • Rango's Avatar
  • OFFLINE
  • Administrator
  • Posts: 848
  • Thank you received: 115
  • Karma: 22
Dear Nirisha Pattlola,

Could you please let me know the name of module you are interesting?

Best regards.
No pain no gain! Accept the pain, future will be fruitful!
The administrator has disabled public write access.
Leather Purses & Handbags, Women’s Crossbody Bags, Tote Bags for Women, Leather Backpacks, Men’s Wallets & Card Cases, Official OLEVS Website, OLEVS Couple Watches, OLEVS Women's Watches, OLEVS Men's Watches, OLEVS Watch, OLEVS Watches